Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline definitions for .md table, .gitignore #17

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

arubdesu
Copy link

We can certainly refine the wording I put in the definitions table, but I think I captured enough of the intent behind each line item. Open to discuss in MacAdmins slack, I'm @allister over there

New .md file to define the criteria, typo fixes, gitignore
@hkystar35
Copy link
Owner

I have concerns about the language in this table. I'm currently dealing with a personal matter, though, and won't be able to give it my full attention for a while still.

@arubdesu
Copy link
Author

arubdesu commented Apr 4, 2024

Totally understandable, I used very explicit, opinionated wording so that boundaries were drawn. But we'd want some kind of consensus so that it's fair and consistent enough in tone, I'm fine revising and/or having my choices overridden if I'm off-base or need reeling in. Thanks!

@arubdesu
Copy link
Author

arubdesu commented May 2, 2024

Hey, if there's some way I can help make this easier/faster to review please let me know. No pressure, but as an option we can also discuss bringing the whole repo to the MacAdmins Open Source team if you're into the idea of group/community participation in maintenance.

Copy link
Owner

@hkystar35 hkystar35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again, thanks for your patience, I was out of the country for a while.
I'm happy to make the changes to MDM/README.md, thanks for catching those glaring typos!

I'm still not sure about adding that Definitions table; I see merit in idea, but I'd want to collaborate more closely before adding into the repo.

@hkystar35 hkystar35 added the question Further information is requested label May 21, 2024
@hkystar35
Copy link
Owner

Here's my counter-proposal:

Keep is all in the same table, but use the <details> html tag

| **Feature** | **Category** | **OS** |
|---|---|---|
| <details><summary><b>Local agent/binary</b></summary>A binary agent installed on the local Mac used to augment capabilities beyond just Apple's Device Management framework. Uses the MDM vendor's communication protocol rather that APNs</details> | Agent | macOS |

Which gives this look:

Feature Category OS
Local agent/binaryA binary agent installed on the local Mac used to augment capabilities beyond just Apple's Device Management framework. Uses the MDM vendor's communication protocol rather that APNs
Agent macOS

@arubdesu
Copy link
Author

Looks great, will update PR accordingly

Another pass at editing the definitions themselves while placing inline in table, hopefully this is closer/better
@arubdesu
Copy link
Author

arubdesu commented Oct 7, 2024

Whoops, I'm out of date with recent merges but should be able to get synced back up shortly

Should make my fork in step with other merges, although I did tweak the 'Forced' ones to start with 'Enforced' and made it consistent that iOS/iPad always comes after macOS
@arubdesu
Copy link
Author

arubdesu commented Oct 7, 2024

PTAL

@arubdesu arubdesu changed the title new 'definitions' .md table, typo fixes, .gitignore inline definitions for .md table, .gitignore Oct 7, 2024
visibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants