-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inline definitions for .md table, .gitignore #17
base: main
Are you sure you want to change the base?
Conversation
New .md file to define the criteria, typo fixes, gitignore
I have concerns about the language in this table. I'm currently dealing with a personal matter, though, and won't be able to give it my full attention for a while still. |
Totally understandable, I used very explicit, opinionated wording so that boundaries were drawn. But we'd want some kind of consensus so that it's fair and consistent enough in tone, I'm fine revising and/or having my choices overridden if I'm off-base or need reeling in. Thanks! |
Hey, if there's some way I can help make this easier/faster to review please let me know. No pressure, but as an option we can also discuss bringing the whole repo to the MacAdmins Open Source team if you're into the idea of group/community participation in maintenance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again, thanks for your patience, I was out of the country for a while.
I'm happy to make the changes to MDM/README.md, thanks for catching those glaring typos!
I'm still not sure about adding that Definitions table; I see merit in idea, but I'd want to collaborate more closely before adding into the repo.
Here's my counter-proposal: Keep is all in the same table, but use the | **Feature** | **Category** | **OS** |
|---|---|---|
| <details><summary><b>Local agent/binary</b></summary>A binary agent installed on the local Mac used to augment capabilities beyond just Apple's Device Management framework. Uses the MDM vendor's communication protocol rather that APNs</details> | Agent | macOS | Which gives this look:
|
Looks great, will update PR accordingly |
Another pass at editing the definitions themselves while placing inline in table, hopefully this is closer/better
Whoops, I'm out of date with recent merges but should be able to get synced back up shortly |
Should make my fork in step with other merges, although I did tweak the 'Forced' ones to start with 'Enforced' and made it consistent that iOS/iPad always comes after macOS
PTAL |
We can certainly refine the wording I put in the definitions table, but I think I captured enough of the intent behind each line item. Open to discuss in MacAdmins slack, I'm @allister over there