Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emacs navigation key-bindings support #2829

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Add Emacs navigation key-bindings support #2829

merged 5 commits into from
Oct 21, 2024

Conversation

janmejay
Copy link
Contributor

Rebase and address review-comments on a very old abandoned change (PR#1039)

  • add emacs-style navigation keymap support (similar to existing Vi keymap support)
  • convert the checkboxes to a set of radio-buttons (one of the open review comments)

@janmejay janmejay requested a review from hluk as a code owner August 30, 2024 18:56
@janmejay
Copy link
Contributor Author

@hluk did you have a chance to look at this?

@hluk
Copy link
Owner

hluk commented Sep 19, 2024

@hluk did you have a chance to look at this?

Not yet. Thanks for the patch! Checking now.

src/common/common.cpp Outdated Show resolved Hide resolved
src/common/common.cpp Outdated Show resolved Hide resolved
src/common/common.cpp Outdated Show resolved Hide resolved
src/gui/mainwindow.cpp Outdated Show resolved Hide resolved
src/gui/traymenu.h Outdated Show resolved Hide resolved
@janmejay
Copy link
Contributor Author

@hluk Sorry for the delay, couldn't get to this until today. Refreshed the PR.

@hluk hluk merged commit 0c8e09d into hluk:master Oct 21, 2024
4 checks passed
@hluk
Copy link
Owner

hluk commented Oct 21, 2024

@janmejay Thanks for the feature! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants