Multi source support for commerce configs and placeholders #286
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
fnhipster
changed the title
…support and remove unused preload link
…fragments from indexing
…te session storage keys
Co-authored-by: Stephen <[email protected]>
… as the default - decorate links for EDS pages - localize links for Blocks
… as the default - localize links for Blocks
… as the default - localize links for checkout block
… as the default - localize links for header block - localize links for product links
This is a content management use case and IMO should not be done in code. For document-based authoring, you can use Excel formula to create a reference to another file and then overwrite values you want to change. Both AEM and DA support language copy rollouts (MSM). |
| @@ -18,6 +18,42 @@ | |||
| </script> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <meta property="og:title" content="Page not found"> | |||
| <script type="module"> | |||
There was a problem hiding this comment.
You can skip this part and hardcode the paths. For multi store we likely would need to have localized 404 pages which then get assigned via CDN. Something like /en/404 and /fr/404 documents which get mapped to the 404 status code using Fastly VCL.
There was a problem hiding this comment.
I'm trying to avoid the need for code changes to add a new language and have that all be driven by the CMS, hence why the root is set at the metadata level. Aside from the folder mapping used for PDP, it's almost possible, but I digress.
What's the harm in having this dynamically set here other than optimizing the 404 page? Perhaps we can add a condition so the fetch is skipped completely if the metadata is present, i.e., already optimized at the CDN level.
There was a problem hiding this comment.
For multi language the 404s would need to be driven by the CMS yes.
What's the harm in having this dynamically set here other than optimizing the 404 page?
No harm, but that 404 wouldn't be localized. Edge Delivery delivers the same 404.html page regardless of the current path which makes it unfeasible for production use cases.
| @@ -503,20 +503,35 @@ function decorateSections(main) { | |||
| */ | |||
| // eslint-disable-next-line import/prefer-default-export | |||
| async function fetchPlaceholders(prefix = 'default') { | |||
| const overrides = getMetadata('placeholders') || ''; | |||
| const [fallback, override] = overrides.split('\n'); | |||
There was a problem hiding this comment.
See my comment on placeholder fallbacks.
| * Decorates links. | ||
| * @param {Element} main The main element | ||
| */ | ||
| export function decorateLinks(main) { |
There was a problem hiding this comment.
This should not be needed once the content was updated accordingly. There shouldn't be any links in the content that point to a URL that does not include the root.
There was a problem hiding this comment.
What about links added to the document? How would those be relative to the root defined?
There was a problem hiding this comment.
You would link to a document like /us/en/welcome.docx, so it matches the actual content structure.
There was a problem hiding this comment.
That's a good point. @anthoula, can you try removing decorateLinks? Document links, such as those in the nav fragment, should be updated and localized.
Co-authored-by: Mark J. Becker <[email protected]>
Interesting. Can you expand some more on this? Do you have any reference I can look at on how to achieved this in a doc-based setup? |
Multi Stores
Multistore refers to a streamlined architecture that enables managing multiple stores with unique catalogs and localization while leveraging a shared code base and unified content delivery.
Overrides Commerce endpoint configs and placeholders based on the
rootpage metadata provided. Otherwise, it defaults to the base/.Metadata are managed as a bulk (https://www.aem.live/docs/bulk-metadata) in metadata.xlsx.
root: path to whereconfigs.xlsxfiles are located. default/](root: Path to the directory where configs.xlsx files are located. Default is /.)placeholders: path to the placeholders.json filer to use. Default/placeholders.json. Adding a path in a new line in this value adds an override file where both paths will be fetched, and the values of the second will override the first.](placeholders: Path to the placeholders.json file to use. The default is /placeholders.json. Adding a new line with another path in this value specifies an override file. Both files will be fetched, and the values in the second file will override those in the first.)☑️ TODO
root/drafts/multistore/*only have theindexat the moment. @anthouladecorateLinks@anthoula/products/: /products/default@fnhipster/helix-query.yamlhttps://multistore--aem-boilerplate-commerce--hlxsites.hlx.page/
https://multistore--aem-boilerplate-commerce--hlxsites.hlx.page/drafts/multistore/en/
https://multistore--aem-boilerplate-commerce--hlxsites.hlx.page/drafts/multistore/en_ca/
Test URLs: