Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimentation v2 integration #77

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Experimentation v2 integration #77

wants to merge 32 commits into from

Conversation

FentPams
Copy link
Collaborator

This PR leverages the upcoming v2 of the experimentation engine (https://github.com/adobe/aem-experimentation) and serves as a demo setup for the new engine.

This will cover:

  • experiments
  • campaigns
  • audiences
    and support use cases for:
  • Page-level modifications
  • Section-level modifications
  • Block/fragment-level modifications

Test URLs:

Xinyi Feng and others added 11 commits June 10, 2024 14:54
remove v1 engine
3e246c3
Squashed 'plugins/experimentation/' content from commit 33c3263
5b251ff 
git-subtree-dir: plugins/experimentation
git-subtree-split: 33c326394030a65b47dcf328f9124bed1adeaff2
Merge commit '5b251ff67e80d6a39dd1cb7e819ca25fb09052aa' as 'plugins/e…
bf1c872 
…xperimentation'
Squashed 'plugins/experimentation/' changes from 33c3263..09f8a72
2b6a7d2 
09f8a72 fix: pill css loading on localhost

git-subtree-dir: plugins/experimentation
git-subtree-split: 09f8a72796f1ca9daeb91e68c62ef4952f5c4254
@FentPams
re-squash the latest v2 with fixed local overlay display issue
4e6769d
@FentPams
fix the conditon of adding experiment plugin
b04889d
@FentPams
Merge commit 'efa27f2bc90a0a346b9dadc1b4e7ec6e1e90eb19' into experime…
e148709 
…ntation-v2-integration
@FentPams
Squashed 'plugins/experimentation/' changes from 09f8a72..638e0db
efa27f2 
638e0db fix: fragment content replacement
c61fdaf doc: update instrumentation details for plugin approach

git-subtree-dir: plugins/experimentation
git-subtree-split: 638e0db53a4fa7886ef9713acc853fc7b02c76be
@FentPams
fix fragment experiment issue on auto-blocking block and regular blocks
30f172d
@FentPams
fix: fetch campigns and audiences in metadata property for page-level…
cdecca4 
… experiment
@FentPams
fix: switch to default page in campaigns has issue on decoration, and…
d284d3d 
… audiences wrongly redirected.
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 24, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 24, 2024 •
edited
Loading

Page Scores Audits Google
M /drafts/xfeng/audiences/fragment PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/audiences/fragment PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/audiences/page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/audiences/page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/audiences/section PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/audiences/section PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/campaigns/fragment PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/campaigns/fragment PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/campaigns/page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/campaigns/page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/campaigns/section PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/campaigns/section PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/experiments/fragment PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/experiments/fragment PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/experiments/page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/experiments/page PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /drafts/xfeng/experiments/section PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /drafts/xfeng/experiments/section PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@FentPams FentPams marked this pull request as ready for review June 24, 2024 15:01
@FentPams FentPams requested a review from ramboz June 24, 2024 15:01
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration June 24, 2024 15:08 Inactive
ramboz
ramboz reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd just remove the package* files from the PR as this is kinda unrelated to the update of the engine

package.json Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration June 26, 2024 19:30 Inactive
@FentPams FentPams force-pushed the experimentation-v2-integration branch from 4d1372b to 5739b00 Compare June 26, 2024 21:32
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration June 26, 2024 21:32 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration June 26, 2024 21:36 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration June 26, 2024 21:52 Inactive
@FentPams FentPams requested a review from ramboz June 26, 2024 21:55
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration July 22, 2024 21:35 Inactive
FentPams and others added 2 commits July 22, 2024 22:10
@FentPams
fix: remove leading hypens in metadata and support customized variant…
4f24236 
… names
@FentPams
Merge pull request #80 from hlxsites/naming-tst
ebafebc 
Support flexible parsing Audience and Campaign from page metadata
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration July 23, 2024 17:03 Inactive
FentPams added 2 commits July 29, 2024 14:33
@FentPams
Squashed 'plugins/experimentation/' changes from 638e0db..9db8662
6cb5857 
9db8662 feat: support customized variant name for fragment variants (#36)
c9ff2c0 fix: only fetch pathname to fix url matching issue (#38)
f7c45aa fix: Support Flexible Parsing (#37)
f29dd80 fix: failing tests following refactoring
9db77eb fix: audience checkpoint name
7dc74e1 feat: prepare data for RUMv2 collection
f6ccbcd fix: update getAllMetadata function (#33)
ae769a2 feat: Supporting Naming Variants in Page Expereimentation (#31)

git-subtree-dir: plugins/experimentation
git-subtree-split: 9db86622117e4327cec042bfc3b16e73a71a4bec
@FentPams
Merge commit '6cb58577ef86d974b603c2e6b0834f026bd60cd2' into experime…
d16a812 
…ntation-v2-integration
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration July 29, 2024 21:35 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration July 29, 2024 21:55 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 5, 2024 14:49 Inactive
FentPams added 2 commits August 7, 2024 08:45
@FentPams
Squashed 'plugins/experimentation/' changes from 9db8662..942948d
6d370f4 
942948d Update: Extract customized names from 'Experiment Variant Name(s)' in page metadata (#41)
5f942a2 feat: Add decoration handler for handling fragment decoration (#39)
9b4478d feat: Central host UI files (#40)

git-subtree-dir: plugins/experimentation
git-subtree-split: 942948d6334265d74d2bfa1342ec015a4c0c64ab
@FentPams
Merge commit '6d370f4e342db8abd5cd8dd49f0d119aa9d6e772' into experime…
0efa8a4 
…ntation-v2-integration
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 7, 2024 15:48 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 7, 2024 16:13 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 8, 2024 15:52 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 13, 2024 14:51 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 13, 2024 15:44 Inactive
@FentPams
Squashed 'plugins/experimentation/' changes from 942948d..d4a5c00
97e67b7 
d4a5c00 test: add tests for page level redirects (#45)
285011f feat: Support page level full redirection (#43)

git-subtree-dir: plugins/experimentation
git-subtree-split: d4a5c00373904a92edd9763ab12b55dd6eed409e
@FentPams
Merge commit '97e67b7207ab00e95c47651061c2cceac4d007d9' into experime…
7553799 
…ntation-v2-integration
@aem-code-sync aem-code-sync bot temporarily deployed to experimentation-v2-integration August 20, 2024 19:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramboz ramboz Awaiting requested review from ramboz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FentPams @ramboz