Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dehardcore paint editor icon colors #333

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

saif-ellafi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Allows for setting icon colors for customized appBars

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Used paintEditorConfigs.style.appBarColor for icon colors of the appBar

Copy link
Owner

@hm21 hm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! I’ll bump the version and proceed with the release. Just a small note: please remember to run dart analyze and resolve any issues, as flutter reduces pub points if there are unresolved problems. I’ll take care of it this time since it’s just related to line length ;)

@hm21 hm21 merged commit 01d2172 into hm21:stable Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants