fixing multiple issues #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates file parsing so that lines that contain solely whitespace (as defined by by Unicode) are ignored. It's fairly common for people to accidentally create CODEOWNERS files with lines containing solely whitespace, and as it's semantically meaningless, it's better to ignore them then raise an error.
While generally disallowed from public github usernames, an underscore is a key part of github EMU usernames. See https://docs.github.com/en/enterprise-cloud@latest/admin/identity-and-access-management/understanding-iam-for-enterprises/about-enterprise-managed-users for more information.
Add `_` as allowed character in usernameRegexp
Update file parsing to handle lines with only whitespace.
integrate haveachin changes
this change adds support for sections, and their inheritance, which are used in gitlab what this does not support, yet, is approval configuration [SECTION][:approval_count:] or optional marking approval as optional
…serOptions public
- support spaces in section names - adds optional ^ character for sections
rwese
commented
Jun 1, 2024
|
Hi @rwese, thanks for submitting this. I've (separately) merged several of the PRs that you'd merged into this one, but it looks like this also contains some other useful changes — in particular, adding optional support for GitLab sections via |
|
Will do, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21, #20, #19, #24, #25