DTSPO-17456 Run tests for global functions #1242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- specify a specific Builder in each pipeline class
charlesluokb
requested review from
SalimKainos,
JakeM-Kainos and
ConnorOKane-Kainos
charlesluokb
commented
Jun 17, 2024
timja
changed the title
timja
reviewed
Jun 18, 2024
| } | ||
|
|
||
| compileGroovy { | ||
| groovyOptions.forkOptions.jvmArgs = [ '-Dgroovy.grape.enable=false' ] | ||
| // @CNP annotation comes from the Jenkins Runtime instance | ||
| exclude '**/pluginActive.groovy' |
There was a problem hiding this comment.
it would fail somehow at the task compileGroovy
timja
reviewed
Jun 18, 2024
…tions-groovy2_4_21' into DTSPO-17456-runTestsForGlobalFuntions-groovy2_4_21
…tions 1. groovy.json.internal.Exceptions$JsonInternalException: unexpected character "." 2. junit.framework.AssertionFailedError: verify[0]: expected 1..1 call(s) to 'setupToolVersion' but was called 0 time(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all of the
Jenkinsfilebased tested were being silently skipped.This happened when groovy was upgraded in a renovate test, in the
groovy-allartifact there's a testing artifact, in version 2.5 this was switched fromJUnit 4toJUnit 5. There was no engine on the classpath forJUnit 4tests and then these were silently being skipped.These haven't been running for quite awhile so there's been a number of changes were additions haven't been made to the tests or syntax has been used that doesn't work in the pipeline library.
The most common problem was type information breaking the tests, a
ClassCastExceptionor aVerifyErrorwould be thrown even though all the inputs matched what should be passed to the function or constructor.The way to fix this was to drop the type information 😢
It might be possible to use a newer groovy and spock version e.g. see jenkinsci/JenkinsPipelineUnit#499 (comment). But its probably safer to leave it as 2.4 as that is what Jenkins is running on and someone might try and use a newer groovy feature than Jenkins supports