Successful Enrolment Page added #355
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byasar3
reviewed
Feb 7, 2025
|
|
||
|
|
||
| def showSuccessfulEnrolmentPage() : Action[AnyContent] = Action.async { implicit request => | ||
| btaAuthorisedAction { implicit ar => |
There was a problem hiding this comment.
ar is not used, so remove implicit ar and replace with _
ie:
{ _ => ...code }
Byasar3
reviewed
Feb 7, 2025
There was a problem hiding this comment.
could you please fix indentation so it's easier to read :')
unfortunately without premium intellij we have to do it manually :(
Byasar3
reviewed
Feb 7, 2025
There was a problem hiding this comment.
can add tests to make sure the hyper link and button are going to the correct places.
if design also required a back button(see jira ticket) then add testing for backlink too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DL-14749 : Added Successful Enrolment Page