NGR-1091 - Amended as per Anna's comments #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| private lazy val otherRadioEmptyError = "landlord.radio.other.empty.error" | ||
| private lazy val otherRadioTooLongError = "landlord.radio.other.tooLong.error" | ||
| private lazy val landlordRadioEmptyError = "landlord.radio.other.empty.error" | ||
| private lazy val landlordRadioTooLongError = "landlord.radio.other.tooLong.error" |
There was a problem hiding this comment.
Do you mean landloardRelationshipTooLongError?
|
|
||
| private def isOtherTextEmpty[A]: Constraint[A] = | ||
| Constraint((input: A) => | ||
| val rentBasedOnForm = input.asInstanceOf[LandlordForm] |
There was a problem hiding this comment.
I know it wasn't you. Can you please change from rentBasedOnForm to landlordForm?
| Some((landlordForm.landlordName, landlordForm.landLordType, landlordForm.landlordOther)) | ||
| Some((landlordForm.landlordName, landlordForm.hasRelationship, landlordForm.landlordRelationship)) | ||
|
|
||
| private def isOtherTextEmpty[A]: Constraint[A] = |
There was a problem hiding this comment.
isLandloardRelationshipTextEmpty?
| Valid | ||
| ) | ||
|
|
||
| private def otherTextMaxLength[A]: Constraint[A] = |
There was a problem hiding this comment.
landLordRelationshipMaxLength?
conf/messages
Outdated
| landlord.name.empty.tooLong.error = Landlord''s full name must be 50 characters or less | ||
| landlord.radio.empty.error = Select what your relationship with the landlord is | ||
| landlord.radio.other.empty.error = Tell us what your relationship with the landlord is | ||
| landlord.radio.other.tooLong.error = Maximum character allowed is 250 |
There was a problem hiding this comment.
Can you please change other to something else? As other doesn't exist any more.
|
|
||
| private def otherTextMaxLength[A]: Constraint[A] = | ||
| Constraint((input: A) => | ||
| val rentBasedOnForm = input.asInstanceOf[LandlordForm] |
There was a problem hiding this comment.
I know it wasn't you. Can you please change from rentBasedOnForm to landlordForm?
anna-shen-hmrc
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR was #57