NGR-1875 - Added Repairs and Fitted Out page #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| case ConfirmBreakClausePage => _ => uk.gov.hmrc.ngrraldfrontend.controllers.routes.LandlordController.show(NormalMode) //TODO This needs to be amended when the journey is completed | ||
| //TODO Next page not made yet | ||
| case RentReviewPage => _ => uk.gov.hmrc.ngrraldfrontend.controllers.routes.CheckRentFreePeriodController.show(NormalMode) | ||
| case RepairsAndFittingOutPage => _ => uk.gov.hmrc.ngrraldfrontend.controllers.routes.LandlordController.show(NormalMode) //TODO This needs to be amended when the journey is completed |
There was a problem hiding this comment.
The previous page is already done. Can you please link it? It looks like only new agreement journey will come to this page.
| } | ||
| <span class="govuk-caption-m">@selectedPropertyAddress</span> | ||
| <h1 class="govuk-heading-l">@messages("repairsAndFittingOut.title")</h1> | ||
| <p class="govuk-hint">@messages("repairsAndFittingOut.p1")</p> |
There was a problem hiding this comment.
It isn't a hint. The color should be black.
|
|
||
| #Repairs and fitting out | ||
| repairsAndFittingOut.title = Repairs and fitting out | ||
| repairsAndFittingOut.p1 = Repairs are when you fix things like poor electrical wiring, leaking windows or a broken toilet. Fitting out is when you install things like air conditioning, a kitchen or carpeting. |
There was a problem hiding this comment.
Maybe you've ran the application and see the radio button question(Have you done any repairs or fitting out in the property?). But I don't see the radio question text being here.
|
|
||
| object Selectors { | ||
| val heading = "#main-content > div > div.govuk-grid-column-two-thirds > form > h1" | ||
| val hint = "#main-content > div > div.govuk-grid-column-two-thirds > form > p" |
There was a problem hiding this comment.
Can you please add radio buttons question?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.