NOJIRA - Fix tests #518
Open
NOJIRA - Fix tests #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gianick
force-pushed
the
NOJIRA-fix-tests
branch
5 times, most recently
from
de880ae to
468a0b9
Compare
gianick
force-pushed
the
NOJIRA-fix-tests
branch
from
468a0b9 to
c443f94
Compare
|
gianick
force-pushed
the
NOJIRA-fix-tests
branch
3 times, most recently
from
3421c01 to
b203805
Compare
|
gianick
force-pushed
the
NOJIRA-fix-tests
branch
from
b203805 to
e5081e2
Compare
|
gianick
force-pushed
the
NOJIRA-fix-tests
branch
3 times, most recently
from
ef52f17 to
cd4e145
Compare
|
… and NfmCaptureTelephoneDetailsViewSpec
…adio buttons test
gianick
force-pushed
the
NOJIRA-fix-tests
branch
from
cd4e145 to
37c870b
Compare
gianick
force-pushed
the
NOJIRA-fix-tests
branch
2 times, most recently
from
65a1fb9 to
22655af
Compare
gianick
force-pushed
the
NOJIRA-fix-tests
branch
from
22655af to
87abe46
Compare
| lazy val formProvider: ContactNfmByPhoneFormProvider = new ContactNfmByPhoneFormProvider | ||
| lazy val page: ContactNfmByPhoneView = inject[ContactNfmByPhoneView] | ||
| lazy val username: String = "John Doe" | ||
| lazy val pageTitle: String = "Can we contact by telephone" // FIXME: telephone? |
There was a problem hiding this comment.
telephone sounds good to me. Why is this a fixme?
There was a problem hiding this comment.
Ah I see, seems it was somehow missed here:
https://jira.tools.tax.service.gov.uk/browse/PIL-2335
Maybe worth raising a ticket as it's a functional change
There was a problem hiding this comment.
Well spotted. Thanks. This is not being used. Will remove it.
| ).toString() | ||
| ) | ||
| lazy val page: FilingMemberCheckYourAnswersView = inject[FilingMemberCheckYourAnswersView] | ||
| lazy val pageTitle: String = "Check your answers for filing member details" |
There was a problem hiding this comment.
You don't seem to use this in the tests below
| } | ||
| } | ||
|
|
||
| "when form has validation errors" should { |
There was a problem hiding this comment.
Why are we removing these tests?
There was a problem hiding this comment.
These are tests that were brought over from the Acceptance Tests and they are redundant because we arleady have the following tests in this spec:
- "when form is submitted with missing values"
- "when form is submitted with values exceeding maximum length"
- "when form is submitted with special characters"
Also the implementation of the BARS-related tests is wrong. A Form[BankAccountDetails] is created with `validForm.withError("accountNumber", "repayments.bankAccountDetails.error.accountNumber"), then passed to the view and then we test if the view has this error message.
dc-smith
reviewed
Oct 17, 2025
test/controllers/repayments/ReasonForRequestingRepaymentControllerSpec.scala
Outdated
Show resolved
Hide resolved
gianick
force-pushed
the
NOJIRA-fix-tests
branch
from
eea91fe to
1ae33b4
Compare
gianick
force-pushed
the
NOJIRA-fix-tests
branch
from
1ae33b4 to
8378ad5
Compare
dc-smith
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tests with outdated, redundant etc tests.
postcodedNonUkAddresstitleandH1ontitleandH1titleandH1titleandH1titleandH1must includefrom view specstest/views/HomepageViewSpec.scala(PR [PIL-2321] - redirect Top Banner Link to DashboardController #516)must include()withmustBe(PR PIL-2722 DEV Add content testing to unit tests 3 #507 & PR PIL-2173: Move commented acceptance test scenarios to frontend from branch PIL-2172 #499)vals, duplicate tests and redundant tests fromviews.repayments.RepaymentsConfirmationViewSpeclazyto val declarations at the top of Specs