Merge pull request #77 from grahampaulcook/master

dropdown helper whitespace padding removal

src/main/twirl/uk/gov/hmrc/play/views/helpers/dropdown.scala.html

@@ -39,9 +39,7 @@
                     id="@elements.field.name-@option._1"
                     value="@option._1"
             @if(value==option._1){selected="selected"}
-            >
-            @option._2
-            </option>
+            >@option._2</option>
         }
     </select>
 </label>

src/test/scala/uk/gov/hmrc/play/views/helpers/DropDownSpec.scala

@@ -0,0 +1,50 @@
+/*
+ * Copyright 2017 HM Revenue & Customs
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package uk.gov.hmrc.play.views.helpers
+
+import org.jsoup.Jsoup
+import org.scalatest.{Matchers, WordSpec}
+import play.api.data.Form
+import play.api.data.Forms.{mapping, _}
+import play.api.i18n.Messages.Implicits._
+import play.api.inject.guice.GuiceApplicationBuilder
+import play.api.test.Helpers._
+import uk.gov.hmrc.play.views.html.helpers.dropdown
+
+class DropDownSpec extends WordSpec with Matchers {
+  implicit val application = new GuiceApplicationBuilder().build()
+
+  case class DummyFormData(country: String)
+
+  def dummyForm = Form(
+    mapping(
+      "country" -> text
+    )(DummyFormData.apply)(DummyFormData.unapply))
+
+  "@helpers.dropDown" should {
+    "render element options" in {
+
+      val countries = Seq("AU" -> "Australia", "JP" -> "Japan")
+
+      val doc = Jsoup.parse(contentAsString(dropdown(dummyForm("country"), countries, displayEmptyValue = false)))
+
+      doc.getElementById("country-AU").outerHtml() shouldBe "<option id=\"country-AU\" value=\"AU\">Australia</option>"
+      doc.getElementById("country-JP").outerHtml() shouldBe "<option id=\"country-JP\" value=\"JP\">Japan</option>"
+    }
+  }
+
+}