BST-111442 - Further test and fixed naming issue for Sneha (#1078)

hmrc · Nov 12, 2024 · f5646f3 · f5646f3
1 parent 986f3ca
commit f5646f3
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/app/form/aboutYourLeaseOrTenure/IsGivenRentFreePeriodForm.scala b/app/form/aboutYourLeaseOrTenure/IsGivenRentFreePeriodForm.scala
@@ -29,7 +29,7 @@ object IsGivenRentFreePeriodForm {
   val isGivenRentFreePeriodForm: Form[AnswersYesNo] =
     Form(
       single(
-        "isGivenRentFreePeriod" -> createYesNoType("error.isGivenRentFreePeriod.required")
+        "rentFreePeriod" -> createYesNoType("error.rentFreePeriod.required")
       )
     )
 

diff --git a/app/views/aboutYourLeaseOrTenure/isGivenRentFreePeriod.scala.html b/app/views/aboutYourLeaseOrTenure/isGivenRentFreePeriod.scala.html
@@ -28,7 +28,7 @@
 
 
 @layout(
-    pageHeading = messages("isGivenRentFreePeriod.heading"),
+    pageHeading = messages("rentFreePeriod.heading"),
     showH1 = false,
     showSection = true,
     summary = Some(request.sessionData.toSummary),
@@ -42,8 +42,8 @@
         @includes.radioButtonsYesNo(
             govukRadios,
             form,
-            "isGivenRentFreePeriod",
-            "isGivenRentFreePeriod.heading",
+            "rentFreePeriod",
+            "rentFreePeriod.heading",
             messages("label.yes.ydy"),
             messages("label.no.nac.ydy"),
             "govuk-fieldset__legend--l",

diff --git a/conf/messages b/conf/messages
@@ -1214,8 +1214,8 @@ error.workCarriedOutCondition.required = Select yes if you were required to carr
 
 # RENT FREE PERIOD
 #########################
-isGivenRentFreePeriod.heading = Were you given a rent-free period, any payment, or any other benefits when the lease or agreement was granted?
-error.isGivenRentFreePeriod.required = Select yes if you were given any rent-free period, payment or benefit
+rentFreePeriod.heading = Were you given a rent-free period, any payment, or any other benefits when the lease or agreement was granted?
+error.rentFreePeriod.required = Select yes if you were given any rent-free period, payment or benefit
 rentFreePeriodDetails.heading = Give details of any rent-free period, payment or benefit
 rentFreePeriodDetails.hint = Leave blank if the rent has been reviewed since the benefit was received.
 error.rentFreePeriodDetails.maxLength = Description of given rent-free period, payment or benefit must be {0} characters or fewer

diff --git a/conf/messages.cy b/conf/messages.cy
@@ -1208,8 +1208,8 @@ error.workCarriedOutCondition.required = Select yes if you were required to carr
 
 # RENT FREE PERIOD
 #########################
-isGivenRentFreePeriod.heading = Were you given a rent-free period, any payment, or any other benefits when the lease or agreement was granted?
-error.isGivenRentFreePeriod.required = Select yes if you were given any rent-free period, payment or benefit
+rentFreePeriod.heading = Were you given a rent-free period, any payment, or any other benefits when the lease or agreement was granted?
+error.rentFreePeriod.required = Select yes if you were given any rent-free period, payment or benefit
 rentFreePeriodDetails.heading = Give details of any rent-free period, payment or benefit
 rentFreePeriodDetails.hint = Leave blank if the rent has been reviewed since the benefit was received.
 error.rentFreePeriodDetails.maxLength = Description of given rent-free period, payment or benefit must be {0} characters or fewer

diff --git a/test/controllers/aboutYourLeaseOrTenure/IsGivenRentFreePeriodControllerSpec.scala b/test/controllers/aboutYourLeaseOrTenure/IsGivenRentFreePeriodControllerSpec.scala
@@ -72,7 +72,7 @@ class IsGivenRentFreePeriodControllerSpec extends TestBaseSpec {
     "Redirect when form data isGivenRentFreePeriod submitted" in {
       val res = isGivenRentFreePeriodController().submit(
         FakeRequest(POST, "/").withFormUrlEncodedBody(
-          "isGivenRentFreePeriod" -> "yes"
+          "rentFreePeriod" -> "yes"
         )
       )
       status(res) shouldBe SEE_OTHER