RS256 signature support; CORS support; i2b2 jwt support #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class CORSFilter implements ContainerResponseFilter { | ||
|
|
||
| @javax.annotation.Resource(mappedName = "java:global/cors_allow_origin") | ||
| private String corsAllowOrigin; |
There was a problem hiding this comment.
This annotation will stop the server during start up when the name binding is missing, which means the default situation will need user to put value in this paramter, but in default, we'd like to disable Cross-Origin Resource Sharing. To implement not interrupting startup procedure, you can take ideas from this code: https://github.com/hms-dbmi/IRCT/blob/master/IRCT-API/src/main/java/edu/harvard/hms/dbmi/bd2k/irct/IRCTApplication.java#L469
There was a problem hiding this comment.
Thanks for the feedback, see the most recent commit which should address the issue.
Anything else problematic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
At The Hyve (https://thehyve.nl) we worked this last month with IRCT, more specifically to bring i2b2 support in the front end Glowing Bear (https://glowingbear.app/) through the PIC-SURE API.
This PR contains some enhancements we made, if you are interested in mainlining them:
Best regards,
Mickaël Misbach