Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ALS-7841] Allow unchecking of facet when count is 0 #356

Merged
merged 3 commits into from
Jan 30, 2025
Merged

[ALS-7841] Allow unchecking of facet when count is 0 #356

merged 3 commits into from
Jan 30, 2025
+57 −1

Conversation

srpiatt
Copy link
Contributor

@srpiatt srpiatt commented Jan 30, 2025

No description provided.

@srpiatt srpiatt added the enhancement New feature or request label Jan 30, 2025
JamesPeck
JamesPeck requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@JamesPeck JamesPeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its forcing me to put something here (${checkedState(facet.name)} is needed)

@srpiatt srpiatt merged commit 382ed28 into release Jan 30, 2025
3 checks passed
@srpiatt srpiatt deleted the feature/ALS-7841 branch January 30, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesPeck JamesPeck JamesPeck approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srpiatt @JamesPeck