fix npe

hms-dbmi · Dec 22, 2023 · b484851 · b484851
1 parent ab8726b
commit b484851
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/...ing/src/main/java/edu/harvard/hms/dbmi/avillach/hpds/processing/VariantListProcessor.java b/...ing/src/main/java/edu/harvard/hms/dbmi/avillach/hpds/processing/VariantListProcessor.java
@@ -144,7 +144,9 @@ public String runVcfExcerptQuery(Query query, boolean includePatientData) throws
 
 		Map<String, String[]> metadata = (metadataIndex == null ? null : metadataIndex.findByMultipleVariantSpec(variantList));
 
-		log.debug("metadata size " + metadata.size());
+		if(metadata == null || metadata.isEmpty()) {
+			return "No Variants Found\n"; //UI uses newlines to show result count
+		}
 
 		// Sort the variantSpecs so that the user doesn't lose their mind
 		TreeMap<String, String[]> metadataSorted = new TreeMap<>((o1, o2) -> {
@@ -153,11 +155,7 @@ public String runVcfExcerptQuery(Query query, boolean includePatientData) throws
 		metadataSorted.putAll(metadata);
 		metadata = metadataSorted;
 
-		if(metadata == null || metadata.isEmpty()) {
-			return "No Variants Found\n"; //UI uses newlines to show result count
-		} else {
-			log.debug("Found " + metadata.size() + " varaints");
-		}
+		log.debug("Found " + metadata.size() + " variants");
 
 		PhenoCube<String> idCube = null;
 		if(!ID_CUBE_NAME.contentEquals("NONE")) {