Site of origin #157
Merged
Site of origin #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Requirement: in order to know where to send data, we need to associate each query with the requester's site - Create table of site code, site name, site email domain - When an institutional query request is made: - Parse the site code from the email of the requesting user - Add that site code to the query request - When persisting a query object after starting a query request - Check for a site code in the query request - Add it to the query meta if it exists - Add some extra niceness for later data transfer work - S3 status code - Interface, implementations for general use, GIC - Repos I verified this change with: - pic-sure-auth-microapp: master and fence branches - pic-sure-gic-common-frontend: Search resource, UUID gen resource
Luke-Sikina
force-pushed
the
site-of-origin
branch
from
ee561b1 to
78d69ed
Compare
|
This was reviewed a few weeks ago, and the sumtype logic was reviewed in its own PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.