[ALS-4774] Add requester email to query request #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke-Sikina
changed the title
Luke-Sikina
commented
Jan 16, 2024
Comment on lines
-295
to
-298
| // we don't want the user to see the common area ID for now, but this could be useful later | ||
| // for editing the query | ||
| response.getResultMetadata().put("commonAreaId", queryEntity.getUuid().toString()); | ||
|
|
There was a problem hiding this comment.
Non formatting change
Luke-Sikina
commented
Jan 16, 2024
| metaData.put("commonAreaUUID", gicRequest.getCommonAreaUUID()); | ||
| metaData.put("site", gicRequest.getInstitutionOfOrigin()); | ||
| metaData.put("sharingStatus", DataSharingStatus.Unknown); | ||
| metaData.put("requesterEmail", gicRequest.getRequesterEmail()); |
There was a problem hiding this comment.
Non formatting change
Luke-Sikina
commented
Jan 16, 2024
Comment on lines
+307
to
+309
| if (response.getResultMetadata() == null) { | ||
| response.setResultMetadata(new HashMap<>()); | ||
| } |
There was a problem hiding this comment.
Non formatting change
Gcolon021
reviewed
Jan 16, 2024
...-sure-resource-api/src/main/java/edu/harvard/dbmi/avillach/domain/FederatedQueryRequest.java
Outdated
Show resolved
Hide resolved
Gcolon021
approved these changes
Jan 16, 2024
Luke-Sikina
force-pushed
the
requester-email
branch
from
11d9fb0 to
ad50c5e
Compare
- Add field to federated query - Add it in agg search resource - Also add some documentation about code formatting
Luke-Sikina
force-pushed
the
requester-email
branch
from
ad50c5e to
1f61ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.