Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build system initial implementation #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

uael
Copy link
Contributor

@uael uael commented Jul 19, 2018

Proposal #5
Related #8 #11
Just an overview of what could be the build system implementation.

Moved includes, sources, bench and tests to separate directories
Disabled tutorial 4 & 5 abort until i find a workaround to handle 'must fail test'
Added a makefile to wrap the CMake build
@uael uael changed the base branch from dev to master July 19, 2018 14:17
@uael
Copy link
Contributor Author

uael commented Jul 22, 2018

Let me known what do you think about this implemetation.
Done/missing list:

  • configuration
    • 32 bits
    • FPENV
    • valgrind
    • address sanitizer
    • coverage
  • debug/release
  • config header ready
  • MSVC ready
  • static/shared lib
  • versioning
  • installation (make install)
  • packaging (cpack)
  • tests
    • success tests
    • fail tests
  • bench
  • travis update
    • platform/compiler matrix
    • configuration matrix (commented)
    • OSX ready (commented)

hnes added a commit that referenced this pull request Jul 24, 2018
hnes pushed a commit that referenced this pull request Jul 24, 2018
@hnes
Copy link
Owner

hnes commented Jul 24, 2018

Thank you very much for your nice contribution, @uael :D

The OSX support has just been added to the master branch of libaco and would be released with the next v1.2.3. I have merged some part of the .travis.yml from this PR into the master branch. Thank you so much for your contribution :D

Unfortunately, because there are some higher priority things to do currently in libaco, so the Proposal "Addition of a build system generator to Test Suites" in Issue #5 would be postponed until all these goals are finished. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants