make lgtm/inspector happy

ocrd_browser/main.py

@@ -2,7 +2,6 @@
 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: t; c-basic-offset: 4; tab-width: 4 -*-
 import os
 import sys
-from pstats import SortKey
 import pstats
 import io
 import cProfile
@@ -49,7 +48,7 @@ def new_hook(type_: Type[BaseException], value: BaseException, traceback: Traceb
 def startup_time() -> None:
     PROFILER.disable()
     s = io.StringIO()
-    ps = pstats.Stats(PROFILER, stream=s).sort_stats(SortKey.TIME)
+    ps = pstats.Stats(PROFILER, stream=s).sort_stats(pstats.SortKey.TIME)
     ps.print_stats(20)
     print(s.getvalue())
 

ocrd_browser/model/document.py

@@ -162,7 +162,7 @@ def baseurl_mets(self) -> str:
         """
         return str(self.workspace.baseurl) + '/' + self.mets_filename if self.workspace else None
 
-    def path(self, other: Union[OcrdFile, Path, str]) -> Path:
+    def path(self, other: Union[OcrdFile, Path, str]) -> Optional[Path]:
         """
         Resolves other relative to current workspace
         """
@@ -445,6 +445,7 @@ def editable(self, editable: bool) -> None:
             if self._original_url:
                 self.workspace = self._clone_workspace(self._original_url)
             else:
+                # noinspection PyTypeChecker
                 self.workspace = Resolver().workspace_from_nothing(directory=None, mets_basename='mets.xml')
         else:
             self.workspace = Resolver().workspace_from_url(self.baseurl_mets)

ocrd_browser/model/page.py

@@ -64,6 +64,7 @@ def file(self) -> Optional[OcrdFile]:
         elif self.image_files:
             return next(iter(self.image_files))
         else:
+            # noinspection PyTypeChecker
             any_files = self.get_files(mimetype=None)
             if any_files:
                 return next(iter(any_files))

ocrd_browser/view/diff.py

@@ -80,7 +80,7 @@ def __init__(self, name: str, window: Gtk.Window):
         self.file_group2: Tuple[Optional[str], Optional[str]] = (None, MIMETYPE_PAGE)
         self.font_size: Optional[int] = None
 
-        self.current2: Page = None
+        self.current2: Optional[Page] = None
 
         # noinspection PyTypeChecker
         self.text_view: GtkSource.View = None

serve.py

@@ -92,7 +92,7 @@ def _browse_workspace(self, path):
             if not path.endswith('mets.xml'):
                 path = os.path.join(path, 'mets.xml')
             ## run app
-            ret = Popen([which('browse-ocrd'),
+            Popen([which('browse-ocrd'),
                          '--display', ':' + str(self.bwport - 8080),
                          path])
             ## proxy does not work, because the follow-up requests would need to be forwarded, too:

setup.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-import fastentrypoints
+import fastentrypoints  # lgtm [py/unused-import]
 import codecs
 import subprocess