final merge from timmy #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into commanderZero
…into commanderZero
Feat: Add community model
all community endpoints (Sourcery refactored)
all community endpoints
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zxenonx
requested changes
Oct 25, 2023
core/settings.py
Outdated
Comment on lines
117
to
126
| 'default': { | ||
| 'ENGINE': 'django.db.backends.postgresql', | ||
| 'NAME': 'neondb', | ||
| 'USER': 'dimeji0518', | ||
| 'PASSWORD': 'cy8vHl7ASYTj', | ||
| 'HOST': 'ep-round-truth-56973996.us-east-2.aws.neon.tech', | ||
| 'PORT': '5432', | ||
| 'OPTIONS': {'sslmode': 'require'}, | ||
| } | ||
|
|
There was a problem hiding this comment.
Do not expose secrets and push them on Github.
This is a dangerous bad practice.
Use env variables.
mentoring/urls.py
Outdated
| path('sessions/<uuid:pk>/delete', views.SessionDeleteView.as_view(), name='session-delete'), | ||
|
|
||
|
|
||
| path('sessions/<uuid:pk>/delete/', views.SessionDeleteView.as_view(), name='session-delete'), |
There was a problem hiding this comment.
Suggested change
| path('sessions/<uuid:pk>/delete/', views.SessionDeleteView.as_view(), name='session-delete'), | |
| path('sessions/<uuid:pk>/', views.SessionDeleteView.as_view(), name='session-delete'), |
mentoring/urls.py
Outdated
| @@ -27,23 +26,19 @@ | |||
| path('resource/<str:id>', views.RetrieveResourceApiView.as_view(), name='resource-detail'), | |||
| path('resource/update/<str:id>/', views.updateResourceApiView.as_view(), name='resource-update'), | |||
There was a problem hiding this comment.
Suggested change
| path('resource/update/<str:id>/', views.updateResourceApiView.as_view(), name='resource-update'), | |
| path('resource/<str:id>/', views.updateResourceApiView.as_view(), name='resource-update'), |
community/views.py
Outdated
| mail = request.user.email | ||
| user = get_object_or_404(CustomUser, email=mail) | ||
| id = kwargs.get("id") | ||
| if id is not None: |
community/views.py
Outdated
Comment on lines
68
to
71
| if member := Members.objects.filter(community=community).first(): | ||
| user_image = member.user.image | ||
| else: | ||
| user_image = None |
There was a problem hiding this comment.
We can remove the else branch
Suggested change
| if member := Members.objects.filter(community=community).first(): | |
| user_image = member.user.image | |
| else: | |
| user_image = None | |
| user_image = None | |
| if member := Members.objects.filter(community=community).first(): | |
| user_image = member.user.image |
There was a problem hiding this comment.
Seems you haven't pushed the changes you've made @timmyades3
Merged
|
Done |
zxenonx
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.