Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validated Slug and UserId #419

Open
wants to merge 12 commits into
base: testing
Choose a base branch
from
Open

Conversation

fortune710
Copy link
Collaborator

@fortune710 fortune710 commented Oct 22, 2023

This PR fixes two bugs. Validated Slug in getPortfolio and Validated user id in getAwards

Description

Validated slug in /portfolio/:slug because I realized that a slug as an empty string could be passed to the backend. Validated user id in /awards/:id because there was no way of checking if the id was in UUID format.

Motivation and Context

This change was to prevent the frontend from sending invalid data to query on the backend

How Has This Been Tested?

Tested on Postman

Screenshots (if appropriate - Postman, etc):


Screenshot (37)

Screenshot (36)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fortune710 fortune710 changed the base branch from dev to testing October 22, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant