fix: Pass arguments to monolith and yt-dlp as array for better escaping

hoarder-app · Nov 3, 2024 · cbaa033 · cbaa033
1 parent 7ec5746
commit cbaa033
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/workers/crawlerWorker.ts b/apps/workers/crawlerWorker.ts
@@ -411,7 +411,7 @@ async function archiveWebpage(
 
   await execa({
     input: html,
-  })`monolith  - -Ije -t 5 -b ${url} -o ${assetPath}`;
+  })("monolith", ["-", "-Ije", "-t", "5", "-b", url, "-o", assetPath]);
 
   const contentType = "text/html";
 

diff --git a/apps/workers/videoWorker.ts b/apps/workers/videoWorker.ts
@@ -98,7 +98,7 @@ async function runWorker(job: DequeuedJob<ZVideoRequest>) {
       `[VideoCrawler][${jobId}] Attempting to download a file from "${url}" to "${assetPath}" using the following arguments: "${ytDlpArguments}"`,
     );
 
-    await execa`yt-dlp ${ytDlpArguments}`;
+    await execa("yt-dlp", ytDlpArguments);
     const downloadPath = await findAssetFile(videoAssetId);
     if (!downloadPath) {
       logger.info(