Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement automatic retry-mechanism for TunnelErrors #199

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

PhilipAB
Copy link
Contributor

@PhilipAB PhilipAB commented Feb 23, 2024

What this PR does / why we need it:
This PR suggests a simple automatic reload mechanism on tunnel errors.

During a test run on Windows scenarios, we had some tunnel errors which were frequently occuring. It would be nice if the client would at least try a few reconnects automatically so that the user does not need to reload the tab manually.

This PR is in draft mode because we need to clarify the following things:

  • should we also implement a retry logic for client connection errors?
  • which interval(s) should we choose for our retry logic?

@jggoebel jggoebel marked this pull request as ready for review March 13, 2024 12:52
@jggoebel jggoebel merged commit cf38581 into hobbyfarm:master Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants