replaced dgram with udx socket in tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafintosh
reviewed
Dec 27, 2023
test/helpers/proxy.js
Outdated
| @@ -31,15 +32,11 @@ module.exports = function proxy ({ from, to, bind } = {}, drop) { | |||
|
|
|||
| function fwd (dropping) { | |||
| if (dropping === true) return | |||
| socket.send(buf, 0, buf.byteLength, port, '127.0.0.1') | |||
| socket.send(buf, port) | |||
rafapaezbas
force-pushed
the
replace-dgram-with-udx
branch
from
907d70f to
c6d9cf0
Compare
mafintosh
reviewed
Dec 27, 2023
| @@ -511,7 +511,7 @@ test('throw in message callback', async function (t) { | |||
|
|
|||
| b.send(b4a.from('hello'), a.address().port) | |||
|
|
|||
| process.once('uncaughtException', async (err) => { | |||
There was a problem hiding this comment.
you need to sniff if you have process and fallback to Bare here,
const handler = typeof process !== 'undefined' ? process : Bare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.