feat: install forge dependencies in postinstall #35
Conversation
.github/workflows/app.yml
Outdated
| - name: Install Foundry | ||
| uses: onbjerg/foundry-toolchain@v1 | ||
| with: | ||
| version: nightly |
There was a problem hiding this comment.
Needing to add this isn't a great side effect, why not add an environment variable to skip forge install rather? (or use the CI environment variable)
There was a problem hiding this comment.
@JasoonS I like that idea – made this a draft for now, I will refactor the postinstall to not run forge install in CI.
There was a problem hiding this comment.
@JasoonS thanks again for the feedback, updated to reflect it!
There was a problem hiding this comment.
Given that this repo expects foundry (even if not used in the isolated context of the app package), I think this kind of change is fine/makes sense, and reflects what your local developer environment might have anyway.
We might consider adding this in as part of #36
Installs forge dependencies in postinstall