Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor bugs and created distribution package for https://www.jsdelivr.com/ #54

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

patrick-yi-82
Copy link

  1. Check related url before using it because json API links must be a string or an object with href and meta
    http://jsonapi.org/format/#document-links

  2. Json API document may not contain "relationships". So check if relationships exist before using it in Object.Keys function.
    http://jsonapi.org/format/#document-resource-objects

  3. Created distribution package for https://www.jsdelivr.com/
    (All packages tagged releases on GitHub are automatically available on jsDelivr.)

https://cdn.jsdelivr.net/gh/holidayextras/jsonapi-client@[release ver]/dist/jsonapi-client.js
https://cdn.jsdelivr.net/gh/holidayextras/jsonapi-client@[release ver]/dist/jsonapi-client.min.js

@pmcnr-hx
Copy link
Contributor

Thank you for the contribution @patrick-yi-82.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants