split out the model generation code #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arnav Gupta <[email protected]>
…re-relationaldb into db-specific-attributes
|
@pmcnr-hx @paparomeo |
|
@championswimmer could this also take care of #53 as you are splitting out by dialect? |
Signed-off-by: Arnav Gupta <[email protected]>
Signed-off-by: Arnav Gupta <[email protected]>
|
@aledalgrande this fixes #53 by making [type] a virtual field |
Signed-off-by: Arnav Gupta <[email protected]>
|
also, @aledalgrande do you think I can target postgres >= 9.4 ?? Are you using < v9.4 ? |
Signed-off-by: Arnav Gupta <[email protected]>
|
@championswimmer using latest stable, so it's fine! |
|
Continues to #75 |
pmcnr-hx
added a commit
that referenced
this pull request
Sep 30, 2017
…ttributes split out the model generation code (contd from #73)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some extra types like JSONB and ARRAY(NUMERIC) we can use for Postgres, let's take advantage of that.