Skip to content

Commit

Permalink
daemon-grpc: fix return value in the GetTransaction RPC
Browse files Browse the repository at this point in the history
As specified in the .proto file, return `grpc::StatusCode::NOT_FOUND`
when the Transaction ID isn't found in the rollback log.

Signed-off-by: Renato Westphal <[email protected]>
  • Loading branch information
rwestphal committed Oct 14, 2024
1 parent 9dae63b commit 6465cbd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion holo-daemon/src/northbound/client/grpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ impl From<northbound::Error> for Status {
Status::resource_exhausted(error.to_string())
}
northbound::Error::TransactionIdNotFound(..) => {
Status::invalid_argument(error.to_string())
Status::not_found(error.to_string())
}
northbound::Error::Get(..) => {
Status::invalid_argument(error.to_string())
Expand Down

0 comments on commit 6465cbd

Please sign in to comment.