bier: BIFT computation and synchronization with Fastclick #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwestphal
reviewed
Oct 22, 2024
There was a problem hiding this comment.
@nrybowski Awesome work! Being able to test the BIER dataplane is super exciting.
The code changes look good to me. I'll be traveling soon, but I'll definitely give this a try when I'm back.
One suggestion: could you gate the FastClick integration behind an optional feature and make reqwest an optional dependency tied to that feature? This might require defining a "fastclick" feature in both the holo-daemon and holo-utils Cargo.toml files.
The CI errors make no sense and should go away with a simple rebase on top of master.
Signed-off-by: Nicolas Rybowski <[email protected]>
Signed-off-by: Nicolas Rybowski <[email protected]>
Signed-off-by: Nicolas Rybowski <[email protected]>
|
Rebase on db22407. |
Signed-off-by: Nicolas Rybowski <[email protected]> Suggested-by: Renato Westphal <[email protected]>
Signed-off-by: Nicolas Rybowski <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the computation of the BIFT upon BIRT update and synchronization with a BIFT implemented as a Fastclick dataplane element.
See also tbarbette/fastclick#397 and #14.
TODO