[yang2] into_raw for Bindings
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yodaldevoid
force-pushed
the
into_raw_yang2
branch
2 times, most recently
from
6628579 to
fdb469f
Compare
|
The CI tests were not run due to the workflow file in |
yodaldevoid
force-pushed
the
into_raw_yang2
branch
2 times, most recently
from
f0dc7e4 to
57337d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## yang2 #22 +/- ##
==========================================
- Coverage 57.20% 56.40% -0.80%
==========================================
Files 7 7
Lines 2124 2154 +30
==========================================
Hits 1215 1215
- Misses 909 939 +30 ☔ View full report in Codecov by Sentry. |
yodaldevoid
force-pushed
the
into_raw_yang2
branch
2 times, most recently
from
17a79b7 to
5cc7948
Compare
Adds methods to get the raw pointer to the libyang structures held by many structures. into_raw has been implemented where the struct manages the pointer (has a Drop impl to free/release the internal struture), and as_raw has been implemented where the struct is just a wrapper.
yodaldevoid
force-pushed
the
into_raw_yang2
branch
from
5cc7948 to
9cda30a
Compare
rwestphal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
Bindings::into_rawto allow turning anyBindinginto its raw pointer.I need this as I am modifying
sysrepo-rsto remove alllibyangbindings, replacing them with the ones from this crate.