Remove idle status #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error in the logic that made peers never become "offline" since the logic to switch the state (
lastSeenToStatus) was only being called if a Pong was received but if a peer is offline, a Pong would never be received.While trying to fix it I noticed that in my opinion the "idle" status does not add a lot of value in that context (someone is either reachable within a certain time span or not reachable). The "idle" status how I'm used to from other applications would more be determined by whether that peer is active in the given application (e.g. whether they have the application focused or move their mouse around).
Since it also makes the solution to the issue simpler this PR therefore removes the "idle" status.