-
Notifications
You must be signed in to change notification settings - Fork 267
Bounded #2164
base: develop
Are you sure you want to change the base?
Conversation
@@ -626,46 +628,51 @@ async fn handle_message_join_space( | |||
) { | |||
sim2h_handle | |||
.state() | |||
.clone() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhh - if we clone the state here the new connection will get added to the clone and not the actual state - then get dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scratch that - I see this is cloning the handle not the state : )
The sim2h side looks awesome! nice work async-ifying everything! |
When I test manually I see lots of problems with not being able to get a lock on state in the action loop. Also you can't ctrl-c out of the conductor any more. |
Using |
Oh yeh I haven't figured out how to get the shutdown to happen on this properly yet. Maybe test it if and then if it's helpful I can look at how to do that. |
PR summary
Adds bounded channels to prevent memory building up in unbounded channels
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation