feat: Remove caching in wasmer_wamr mode #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mattyg
changed the title
mattyg
changed the title
…is only exposed in wasmer_wamr mode, rename error variant for accuracy
mattyg
changed the title
…ture flag conditionals that make the consuming code more complex and harder to understand
mattyg
commented
Dec 14, 2024
| Compile(String), | ||
| /// Wasmer failed to build a Module from wasm byte code. | ||
| /// With the feature `wasmer_sys` enabled, building a Module includes compiling the wasm. | ||
| ModuleBuild(String), |
There was a problem hiding this comment.
Rename error type to clarify that it is an error arising when creating a new wasmer Module. Only in wasmer_sys mode does compilation occur here.
mattyg
commented
Dec 14, 2024
| use super::build_module; | ||
|
|
||
| #[test] | ||
| fn build_module_test() { |
There was a problem hiding this comment.
smoke test for building a wasm module in wasmer_wamr mode.
…ule-outside-cache
…ule-outside-cache
mattyg
commented
Dec 14, 2024
| @@ -54,6 +54,11 @@ pub(crate) fn make_runtime_engine() -> Engine { | |||
| Engine::headless() | |||
| } | |||
|
|
|||
| /// Build an interpreter module from wasm bytes. | |||
| pub fn build_module(_wasm: &[u8]) -> Result<Arc<Module>, wasmer::RuntimeError> { | |||
| unimplemented!("The feature flag 'wasmer_wamr' must be enabled to support building a Module directly. Please use the ModuleCache instead."); | |||
There was a problem hiding this comment.
This is keep a consistent api so we don't need to use conditional feature flags in the consumer.
I recognize this is silly, since the function below build_module_for_ios does the same thing. But for clarity I'd like to wait to remove that til we remove the "prebuilt ios modules" functionality in its entirety.
mattyg
changed the title
ThetaSinner
approved these changes
Dec 18, 2024
Co-authored-by: ThetaSinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
wasmer_wamrmode, expose a public functionbuild_moduleto build a wasm module directly, bypassing the cache.This is a prerequisite for holochain/holochain#4441
This PR is merging into
chore/cleanup-make-privatefor a more legible diff.