-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: when deserialization of module from filesystem cache fails, remove from cache #138
Merged
+140
−47
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4f22138
feat: remove in-memory SerializedModuleCache, move logic to perist se…
mattyg 206b95c
chore: cleaner docs
mattyg a169d06
chore: fmt + clippy
mattyg f698eb2
chore: rename fn for clarity
mattyg e0fa1f3
chore: clearer code
mattyg 161da4d
feat: when deserialization of module from filesystem cache fails, rem…
mattyg 9bcd47d
chore: comment clarity
mattyg 979c8c2
chore: wording
mattyg 4fd21aa
chore: link to github discussion
mattyg 01e8f77
chore: clearer simpler naming without redundant 'Serialized' and 'Des…
mattyg b5d8a7f
refactor: separate concerns ModuleBuilder from ModuleCache
mattyg 9cc268a
Merge branch 'feat/rm-serialized-module-cache' into fix/corrupted-cac…
mattyg 781ade3
feat: tracing log when deleting file fails, re-build wasm and save to…
mattyg 46a3686
test: use TempDir so dir is deleted on Drop
mattyg c3f8f08
Merge branch 'main' into fix/corrupted-cached-file
mattyg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,11 @@ version = "0.0.97" | |
authors = ["thedavidmeister", "[email protected]"] | ||
edition = "2021" | ||
|
||
[lib] | ||
name = "holochain_wasmer_host" | ||
crate-type = ["cdylib", "rlib"] | ||
path = "src/lib.rs" | ||
|
||
[dependencies] | ||
wasmer = { version = "5.0.2", default-features = false } | ||
wasmer-middlewares = { version = "5.0.2", optional = true } | ||
|
@@ -20,10 +25,8 @@ bytes = "1" | |
hex = "0.4" | ||
thiserror = "2" | ||
|
||
[lib] | ||
name = "holochain_wasmer_host" | ||
crate-type = ["cdylib", "rlib"] | ||
path = "src/lib.rs" | ||
[dev-dependencies] | ||
tempfile = "3.14.0" | ||
|
||
[features] | ||
default = ["error_as_host", "wasmer_sys_dev"] | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional error types for clarity