refactor: don't take ModuleBuilder in construction of ModuleCache #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead just construct a new default ModuleBuilder. Remove tests against wasmer_sys_* features without wasm metering, as this is not used anywhere and not exposed for configuration
mattyg
commented
Jan 15, 2025
There was a problem hiding this comment.
Removes tests of feature wasmer_sys with metering disabled, as this is not used anywhere and not exposed as an option for consumers.
|
Superseded by #145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I split out the
ModuleBuilderfrom theModuleCachehastily in #136 and didn't wait for review (my bad).This modifies the implementation so that a default
ModuleBuilderis constructed when theModuleCacheis constructed. Nothing about theModuleBuilderis exposed to consumers. Holochain was not modifying the default setup anyway.This also removes tests with wasm metering disabled, as this is not used anywhere and no longer exposed for configuration.
TODO: