sbd integration into tx5 #91
Conversation
neonphog
changed the title
| ConnCmd::SigRecv(sig) => { | ||
| use tx5_signal::SignalMessage::*; | ||
| #[allow(clippy::single_match)] // placeholder | ||
| match sig { | ||
| // invalid | ||
| HandshakeReq(_) | HandshakeRes(_) => break, | ||
| Message(msg) => { | ||
| if msg_send.send(msg).await.is_err() { | ||
| break; | ||
| } | ||
| } | ||
| _ => (), | ||
| } | ||
| } |
There was a problem hiding this comment.
Here's the webrtc placeholder. Currently we're just dealing with the Message type, but eventually we'll pay attention to offers/answers/ice and try to establish a webrtc connection, switching to it if it is successful.
| stats::Stats { | ||
| backend, | ||
| peer_url_list: self.get_listening_addresses(), | ||
| connection_list: Vec::new(), |
There was a problem hiding this comment.
Note, this just returns an empty array for now. I'll flesh out the stats once we have the webrtc connections working.
.github/workflows/stale.yml
Outdated
There was a problem hiding this comment.
Just not useful on this repo?
There was a problem hiding this comment.
exactly. The volume isn't high enough to warrant it, and it doesn't have the permanent label... if we ever need it, we can port the one from holochain over here.
There was a problem hiding this comment.
This is large as advertised. I think I'm following most of the changes and they make sense! I'm calling this a 'high level' approval where I think the structure of the changes and the code looks good. If there are logic errors in loops or task management etc then I'm probably not going to catch it in this much code :)
| @@ -15,7 +15,7 @@ resolver = "2" | |||
| [workspace.dependencies] | |||
| app_dirs2 = "2.5.5" | |||
| backtrace = "0.3.69" | |||
| base64 = "0.13.0" | |||
| base64 = "0.22.1" | |||
DEPENDS ON: holochain/sbd#1
RESOLVES: holochain/sbd#17