Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement/add latest holograph genesis package 0.2.0 #12

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sogoiii
Copy link
Contributor

@sogoiii sogoiii commented Feb 7, 2024

Describe Changes

Changes made to the package: holograph-genesis.

I made it better by doing ...

  • Add holograph genesis 0.2.0
  • NOTE: this is no an exact copy. I made the following changes
    • Removed husky from package
    • Updated node version
    • Using pnpm instead of yarn
    • Overrides node-hid using pnpm.overrides

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code styles have been enforced
  • All tests are passing

@sogoiii sogoiii changed the title improvement/add latest holograph genesis package improvement/add latest holograph genesis package 0.2.0 Feb 7, 2024
Copy link
Contributor

@alexanderattar alexanderattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sogoiii is there something else used instead of husky now?

Is pnpm compatible with the yarn override we do for node-hid? IIRC npm and yarn handle this differently so maybe it's the same for pnpm

"resolutions": {
"node-hid": "github:holographxyz/node-hid#feature/guard-against-reinstantiating-connection"
}

@sogoiii
Copy link
Contributor Author

sogoiii commented Feb 7, 2024

@sogoiii is there something else used instead of husky now?

Is pnpm compatible with the yarn override we do for node-hid? IIRC npm and yarn handle this differently so maybe it's the same for pnpm

"resolutions": { "node-hid": "github:holographxyz/node-hid#feature/guard-against-reinstantiating-connection" }

Good questions. I only moved over to pnpm because thats what the repo is using. From their feature chart, it does look like it is compatible.

image

How would i verify that the node-hid resolution works as expected? Should i try to sign something with my ledger?

@sogoiii sogoiii marked this pull request as draft February 9, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants