Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate colorcet to using pixi for development #128

Merged
merged 26 commits into from
Mar 14, 2025
Merged

Conversation

Azaya89
Copy link
Contributor

@Azaya89 Azaya89 commented Mar 10, 2025

This PR migrates the developer workflow to Pixi. This is aligned with what has already been done for holoviews and hvPlot:

  • Create pixi.toml to use approach adopted by hvPlot
  • Ensure the tests / docs / build workflow work as expected
  • Create the developer guide page in the docs

@Azaya89 Azaya89 requested a review from hoxbro March 10, 2025 19:59
@Azaya89 Azaya89 self-assigned this Mar 10, 2025
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first iteration of this migration. I have left some comments for you (and one for me).

I haven't read the developer_guide.md, but if you haven't already, double-check that everything is also valid for colorcet.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (34b3992) to head (5f3f9c6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #128       +/-   ##
===========================================
+ Coverage   85.70%   95.89%   +10.19%     
===========================================
  Files           8        6        -2     
  Lines        1938     1609      -329     
===========================================
- Hits         1661     1543      -118     
+ Misses        277       66      -211     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Azaya89 Azaya89 requested a review from hoxbro March 12, 2025 15:57
@hoxbro
Copy link
Member

hoxbro commented Mar 14, 2025

I don't think you have pushed the changes to this PR.

@Azaya89
Copy link
Contributor Author

Azaya89 commented Mar 14, 2025

I don't think you have pushed the changes to this PR.

Done now.

@Azaya89 Azaya89 requested a review from hoxbro March 14, 2025 10:59
Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are almost there.

Can you thoroughly look at the changes and ensure that nothing is missed?

Also, remember to open an issue about dropping EOL Python versions.

@Azaya89
Copy link
Contributor Author

Azaya89 commented Mar 14, 2025

I think everything is fine now...

@hoxbro hoxbro merged commit 5188c79 into holoviz:main Mar 14, 2025
12 checks passed
@hoxbro
Copy link
Member

hoxbro commented Mar 14, 2025

@hoxbro
Copy link
Member

hoxbro commented Mar 14, 2025

Fixed in #129

@hoxbro
Copy link
Member

hoxbro commented Mar 14, 2025

Other than that, everything went great with a dev release.

Great job!

@Azaya89
Copy link
Contributor Author

Azaya89 commented Mar 14, 2025

Thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants