-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate colorcet to using pixi for development #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great first iteration of this migration. I have left some comments for you (and one for me).
I haven't read the developer_guide.md, but if you haven't already, double-check that everything is also valid for colorcet.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
===========================================
+ Coverage 85.70% 95.89% +10.19%
===========================================
Files 8 6 -2
Lines 1938 1609 -329
===========================================
- Hits 1661 1543 -118
+ Misses 277 66 -211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't think you have pushed the changes to this PR. |
Done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are almost there.
Can you thoroughly look at the changes and ensure that nothing is missed?
Also, remember to open an issue about dropping EOL Python versions.
I think everything is fine now... |
PyPi publish step failed: https://github.com/holoviz/colorcet/actions/runs/13862842237/job/38795500998 |
Fixed in #129 |
Other than that, everything went great with a dev release. Great job! |
Thank you for the help! |
This PR migrates the developer workflow to Pixi. This is aligned with what has already been done for holoviews and hvPlot:
pixi.toml
to use approach adopted by hvPlot