Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and small Pixi improvements #6200

Merged
merged 42 commits into from
May 3, 2024
Merged

Update documentation and small Pixi improvements #6200

merged 42 commits into from
May 3, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 20, 2024

Follow up to #6182, where we must align the rest of the documentation with the changes. I will also update these files to markdown.

It's not directly related, but I also want to update the changelog to only change once. I also removed .gitattribute as it is no longer needed.

I will also update this PR based on things I do it the Panel PR.
Todo based on work on panel

  • Coverage trick
  • Install only when needed on build step
  • Make it so you can run the unit test without additional dependencies

@hoxbro hoxbro added the type: docs Related to the documentation and examples label Apr 20, 2024
@hoxbro hoxbro marked this pull request as draft April 20, 2024 09:51
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 88.22%. Comparing base (8507aab) to head (f98ef05).
Report is 3 commits behind head on main.

Files Patch % Lines
holoviews/tests/core/test_options.py 62.96% 10 Missing ⚠️
holoviews/tests/operation/test_operation.py 63.63% 4 Missing ⚠️
holoviews/tests/util/test_utils.py 55.55% 4 Missing ⚠️
holoviews/tests/core/test_storeoptions.py 62.50% 3 Missing ⚠️
holoviews/tests/test_selection.py 60.00% 2 Missing ⚠️
holoviews/tests/conftest.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6200      +/-   ##
==========================================
+ Coverage   88.10%   88.22%   +0.12%     
==========================================
  Files         319      321       +2     
  Lines       67158    67285     +127     
==========================================
+ Hits        59168    59361     +193     
+ Misses       7990     7924      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro force-pushed the pixi2 branch 3 times, most recently from f7ef287 to 4d80186 Compare April 26, 2024 12:08
Comment on lines +121 to +124
- name: Install test dependencies
run: python -m pip install "$(ls dist/*whl)[tests]"
- name: Test package
run: python -m pytest --pyargs $PACKAGE --color=yes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is actually needed.

README.md Outdated Show resolved Hide resolved
@hoxbro hoxbro changed the title Update documentation Update documentation and small Pixi improvements May 3, 2024
@hoxbro
Copy link
Member Author

hoxbro commented May 3, 2024

I will merge this as is. Again nothing is set in stone.

(This will also fix the current failing CI)

@hoxbro hoxbro enabled auto-merge (squash) May 3, 2024 12:52
@hoxbro hoxbro added type: maintenance infrastructure and maintenance of CI and removed type: docs Related to the documentation and examples labels May 3, 2024
@hoxbro hoxbro enabled auto-merge (squash) May 3, 2024 14:17
@hoxbro hoxbro disabled auto-merge May 3, 2024 14:29
@hoxbro hoxbro enabled auto-merge (squash) May 3, 2024 14:29
@hoxbro hoxbro merged commit b1fe1cf into main May 3, 2024
14 checks passed
@hoxbro hoxbro deleted the pixi2 branch May 3, 2024 14:48
@hoxbro hoxbro mentioned this pull request May 15, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant