Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: plotly 6.0 #6504

Merged
merged 10 commits into from
Feb 3, 2025
Merged

compat: plotly 6.0 #6504

merged 10 commits into from
Feb 3, 2025

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 31, 2025

Two big things with the plotly 6.0 release

  1. The fig_dict no longer outputs numpy arrays but a special dict with information to create it. I have made a util for this.
  2. scattermapbox is deprecated for scattermap, and by that logic, mapbox is deprecated for map, emits this warning: *scattermapbox* is deprecated! Use *scattermap* instead. Learn more at: https://plotly.com/python/mapbox-to-maplibre/. accesstoken is not needed for the new implementation and will give an error.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 94.17476% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.77%. Comparing base (d9861ae) to head (3a12185).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/plotting/plotly/tiles.py 60.00% 4 Missing ⚠️
holoviews/tests/plotting/plotly/test_tiles.py 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6504      +/-   ##
==========================================
- Coverage   88.79%   88.77%   -0.03%     
==========================================
  Files         323      323              
  Lines       68731    68772      +41     
==========================================
+ Hits        61028    61049      +21     
- Misses       7703     7723      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as ready for review February 3, 2025 11:46
@hoxbro hoxbro enabled auto-merge (squash) February 3, 2025 11:46
@hoxbro hoxbro merged commit e88f265 into main Feb 3, 2025
14 checks passed
@hoxbro hoxbro deleted the compat_plotly branch February 3, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant