-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Add formatter to Server HoverTool #6531
base: main
Are you sure you want to change the base?
Conversation
hoxbro
commented
Mar 10, 2025
•
edited
Loading
edited
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6531 +/- ##
==========================================
+ Coverage 88.79% 88.81% +0.01%
==========================================
Files 323 323
Lines 68960 68988 +28
==========================================
+ Hits 61236 61270 +34
+ Misses 7724 7718 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Opened an issue in Bokeh: bokeh/bokeh#14413 |
We should merge this PR as is, as the datetime fix will likely sort itself with an upstream fix. |
if BOKEH_GE_3_7_0: | ||
data_coords = {dim: data_sel['coords'][dim]['data'] for dim in coords} | ||
else: | ||
data_coords = {dim: round(data_sel['coords'][dim]['data'], 3) for dim in coords} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be OK with me to only have the BOKEH_GE_3_7_0
code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the behavior for older bokeh versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for the x,y-coords, so it would show 1.999999999999
instead of 2.0
.
Though, I'm unsure how it would work if x,y-coords are datetime.