-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor SQL agent #1010
Refactor SQL agent #1010
Conversation
I think this is a nice improvement in principle but I've also found issues and am not confident I can track them all down. |
Maybe test more and merge after announcement/release then? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 57.47% 57.65% +0.18%
==========================================
Files 109 109
Lines 14262 14212 -50
==========================================
- Hits 8197 8194 -3
+ Misses 6065 6018 -47 ☔ View full report in Codecov by Sentry. |
The goal of this PR is to simplify SQLAgent and make it run faster by reducing the number of steps to output SQL.
Changes:
select_table
,require_joins
,find_joins
intofind_tables
.<->
was really hard to look at, compared to:::
make_tables_model
also highlights issues when joining