Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export issues #1018

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix export issues #1018

merged 2 commits into from
Jan 30, 2025

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 30, 2025 •
edited
Loading

image

philippjfr
philippjfr reviewed Jan 30, 2025
View reviewed changes
lumen/ai/export.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes missing coverage. Please review.

Project coverage is 57.71%. Comparing base (861d49f) to head (1c47446).
Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
lumen/ai/export.py 25.00% 18 Missing ⚠️
lumen/sources/duckdb.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
- Coverage   58.40%   57.71%   -0.70%     
==========================================
  Files         109      109              
  Lines       13915    14193     +278     
==========================================
+ Hits         8127     8191      +64     
- Misses       5788     6002     +214

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 changed the title export while placeholder Fix export issues Jan 30, 2025
@ahuang11 ahuang11 requested a review from philippjfr January 30, 2025 20:25
@philippjfr philippjfr merged commit 6199843 into main Jan 30, 2025
11 of 12 checks passed
@philippjfr philippjfr deleted the export_while_placeholder branch January 30, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahuang11 @philippjfr