Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unformatted strings (MERGE BEFORE RELEASE) #867

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

Found a couple missing unformatted strings
https://github.com/holoviz/lumen/pull/854/files

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (04fc98e) to head (0bdf0c9).

Files with missing lines Patch % Lines
lumen/ai/tools.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   57.12%   57.11%   -0.01%     
==========================================
  Files         108      108              
  Lines       13635    13637       +2     
==========================================
  Hits         7789     7789              
- Misses       5846     5848       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahuang11 ahuang11 merged commit 81e9dc0 into main Dec 14, 2024
12 checks passed
@ahuang11 ahuang11 deleted the fix_unformatted branch December 14, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants