Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid redundant list operations in ListLike #7764

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

s-alexey
Copy link
Contributor

@s-alexey s-alexey commented Mar 7, 2025

  • Removed list() casts and concatenations in __add__ and __radd__ methods of ListLike and NamedListLike containers.

s-alexey and others added 2 commits March 7, 2025 10:58
- Removed `list()` casts and addintion in `__add__` and `__radd__` methods of `ListLike` and `NamedListLike` containers.
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (f4f6035) to head (842e0ab).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
panel/layout/base.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7764       +/-   ##
===========================================
+ Coverage   71.23%   86.65%   +15.41%     
===========================================
  Files         345      346        +1     
  Lines       52792    52791        -1     
===========================================
+ Hits        37609    45744     +8135     
+ Misses      15183     7047     -8136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hoxbro hoxbro changed the title Refactor: Avoid redundant list operations in ListLike perf: Avoid redundant list operations in ListLike Mar 12, 2025
@hoxbro hoxbro enabled auto-merge (squash) March 13, 2025 11:41
@hoxbro
Copy link
Member

hoxbro commented Mar 13, 2025

Thank you

@hoxbro hoxbro merged commit afa745c into holoviz:main Mar 13, 2025
49 of 53 checks passed
@s-alexey s-alexey deleted the refactor-base branch March 14, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants