Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure IconButton tooltip timer is cleared on multiple mouseenter events #7798

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

philippjfr
Copy link
Member

In certain situation it seems like the description tooltip on an IconButton wasn't cleared correctly. I wasn't able to reproduce myself but added some handling around avoiding race conditions with multiple mouseenter events firing and using the more reliable pointerleave event.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (c77396f) to head (d7404ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7798      +/-   ##
==========================================
+ Coverage   86.08%   87.08%   +0.99%     
==========================================
  Files         346      346              
  Lines       52970    52970              
==========================================
+ Hits        45600    46127     +527     
+ Misses       7370     6843     -527     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr enabled auto-merge (squash) March 20, 2025 21:50
@philippjfr philippjfr disabled auto-merge March 20, 2025 21:50
@philippjfr philippjfr merged commit 0f46443 into main Mar 20, 2025
30 of 35 checks passed
@philippjfr philippjfr deleted the icon_button_timeout_clear branch March 20, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant