Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pre-processors to ESM children #7799

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Conversation

philippjfr
Copy link
Member

An oversight in the way ESM components implemented rendering of children meant that preprocessors weren't applied. This meant functionality such as HoloViews linking and the application of design modifiers didn't happen in some scenarios.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (b6ae1ed) to head (3bc5b12).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/custom.py 91.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7799       +/-   ##
===========================================
+ Coverage   71.35%   87.10%   +15.74%     
===========================================
  Files         345      346        +1     
  Lines       52945    52970       +25     
===========================================
+ Hits        37781    46137     +8356     
+ Misses      15164     6833     -8331     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit c77396f into main Mar 20, 2025
17 of 18 checks passed
@philippjfr philippjfr deleted the esm_children_preprocessors branch March 20, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant