Drop gmpy support in favor of gmpy2 #1026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661
#971 added
gmpy2
in thepixi.toml
file instead ofgmpy
, which are two different projects (the former being maintained while the latter hasn't received an update since 2013). The test suite wasn't updated accordingly so the gmpy-related tests were all skipped (attempting to importgmpy
instead ofgmpy2
).This MR lets us "officially" drop support of the
gmpy
Python library (which probably no one used with Param?) in favor ofgmpy2
.I'm not entirely sure Param should keep supporting that but ensuring the test suite passes with gmpy2 wasn't too much work. I'd be okay if someone pushes to deprecate it.