Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop gmpy support in favor of gmpy2 #1026

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Drop gmpy support in favor of gmpy2 #1026

merged 1 commit into from
Feb 16, 2025

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Feb 15, 2025

Closes #661

#971 added gmpy2 in the pixi.toml file instead of gmpy, which are two different projects (the former being maintained while the latter hasn't received an update since 2013). The test suite wasn't updated accordingly so the gmpy-related tests were all skipped (attempting to import gmpy instead of gmpy2).

This MR lets us "officially" drop support of the gmpy Python library (which probably no one used with Param?) in favor of gmpy2.

I'm not entirely sure Param should keep supporting that but ensuring the test suite passes with gmpy2 wasn't too much work. I'd be okay if someone pushes to deprecate it.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (aa3315a) to head (982d8d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   87.25%   87.27%   +0.02%     
==========================================
  Files           9        9              
  Lines        4928     4928              
==========================================
+ Hits         4300     4301       +1     
+ Misses        628      627       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Supporting gmpy2 is important for anyone using param for a simulator, where exact arithmetic is necessary to avoid subtle bugs, so I'm glad this is being updated.

@maximlt maximlt merged commit facb9e5 into main Feb 16, 2025
16 checks passed
@maximlt maximlt deleted the gmpy2_support branch February 16, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade gmpy support to gmpy2
2 participants