Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print_all_param_defaults function #1029

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Feb 16, 2025

Normally, removing some API should go through a deprecation period, but this one is special in the sense that it was so lost (undocumented, untested, unused) that it is broken! Indeed, Parameterized classes no longer have a print_param_defaults method, it is installed on the .param namespace (funnily, it's deprecated).

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (058f77a) to head (35bf42a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   87.28%   87.46%   +0.18%     
==========================================
  Files           9        9              
  Lines        4946     4948       +2     
==========================================
+ Hits         4317     4328      +11     
+ Misses        629      620       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt maximlt merged commit 9ff6a9f into main Feb 21, 2025
17 checks passed
@maximlt maximlt deleted the remove_print_all_param_defaults branch February 21, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant